Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default buffer size for stream reader #1466

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

aishwaryabh
Copy link
Contributor

Issue describing the changes in this PR

The buffer size for the stream reader was initially set to -1, but this causes issues in .NET framework 4.8 as it expects a positive number. Looking at the source code for .NET framework 4.8, the default value is set to be 1024 if legacy isn't enabled. I also see in the documentation here that the default is set to be 1024 for later .NET versions.

resolves #issue_for_this_pr

Pull request checklist

  • [x ] My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • [x ] My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • [x ] My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • [x ] I have added all required tests (Unit tests, E2E tests) (not needed since this is a bug fix)

@aishwaryabh aishwaryabh merged commit 8502374 into main Apr 13, 2023
23 checks passed
@aishwaryabh aishwaryabh deleted the aibhandari/changeDefaultBufferSize branch April 13, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpRequestDataExtensions.ReadAsStringAsync fails on .NET Framework
2 participants