Including worker metadata & capabilities in env reload response #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satvu
reviewed
Mar 21, 2023
satvu
reviewed
Mar 21, 2023
satvu
reviewed
Mar 21, 2023
satvu
reviewed
Mar 21, 2023
satvu
reviewed
Mar 21, 2023
satvu
approved these changes
Mar 21, 2023
liliankasem
approved these changes
Mar 22, 2023
fabiocav
requested changes
Mar 22, 2023
ghost
added
No. The host gracefully handles this situation. |
…native host mode.
…adata and capabilities based on hosting model.
kshyju
force-pushed
the
shkr/env-reload-worker
branch
from
a39453f
to
3bcd33b
Compare
kshyju
changed the title
kshyju
commented
Mar 22, 2023
| return envReloadResponse; | ||
| } | ||
|
|
||
| private static WorkerMetadata GetWorkerMetadata() |
There was a problem hiding this comment.
content of this method is existing code. Moved to this method so that it can be called from worker init handler and env reload response handler.
kshyju
commented
Mar 22, 2023
| return workerMetadata; | ||
| } | ||
|
|
||
| private static IDictionary<string, string> GetWorkerCapabilities(WorkerOptions workerOptions) |
There was a problem hiding this comment.
content of this method is existing code. Moved to this method so that it can be called from worker init handler and env reload response handler.
liliankasem
approved these changes
Mar 22, 2023
fabiocav
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worker side changes to address Azure/azure-functions-host#8983.
Including worker metadata and capabilities in env reload response.
Host side changes were made in Azure/azure-functions-host#9020
There is some changes in the native worker as well to make this work. But will keep that changes in separate PR.