Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Samples] Updated EF sample project to NET 6 & V4 #1068

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Conversation

kshyju
Copy link
Member

@kshyju kshyju commented Sep 27, 2022

We updated sample projects to V4 and NET6 in #786 , but left the EF sample project. Updating that as well in this PR.

Also renamed the project to be more generic (net-5-entity-framework.csproj to EntityFramework.csproj)

@kshyju kshyju changed the title Updated EF sample project to NET 6 & V4 [Samples] Updated EF sample project to NET 6 & V4 Sep 27, 2022
Copy link
Member

@liliankasem liliankasem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - some comments

Copy link
Member

@satvu satvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kshyju
Copy link
Member Author

kshyju commented Sep 28, 2022

/check-enforcer evaluate

@kshyju kshyju merged commit 1f7a321 into main Sep 28, 2022
@kshyju kshyju deleted the shkr/net6-ef-sample branch September 28, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants