ci: remove beta kubernetes os selector #3501
Merged
+17
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the deprecated "beta.kubernetes.io/os" key with "kubernetes.io/os" across several manifests and pipeline configurations to fix the cilium nightly pipeline failure.
- Updated node selectors in deployment, daemonset, and master manifests
- Modified pipeline YAML configurations to reflect the new key
- Adjusted test manifests to use the current OS label
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/acncli/deployment/manager_swift.yaml | Updated node selector for OS label |
| hack/toolbox/manifests/daemonset.yaml | Updated node selector for OS label |
| hack/toolbox/manifests/master.yaml | Updated node selector for OS label in multiple pods |
| .pipelines/mdnc/azure-cns-cni-1.5.4.yaml | Updated node selector key in pipeline config |
| test/scale/templates/kwok-node.yaml | Updated template label; possible duplicate OS labels detected |
| test/integration/manifests/cilium/cns-write-ovly.yaml | Updated node selector key in integration test manifest |
| hack/toolbox/manifests/agents.yaml | Updated node selector for OS label in agents manifests |
| .pipelines/mdnc/azure-cns-cni-1.4.39.1.yaml | Updated node selector key in pipeline config |
| test/integration/manifests/cns/daemonset-linux.yaml | Updated node selector key in integration test manifest |
| cns/azure-cns.yaml | Updated node selector key in CNS config |
| .pipelines/mdnc/azure-cns-cni-1.5.28.yaml | Updated node selector key in pipeline config |
| hack/manifests/cni-installer.yaml | Updated node selector key in installer config |
| .pipelines/mdnc/azure-cns-cni.yaml | Updated node selector key in pipeline config |
QxBytes
force-pushed
the
alew/remove-beta-os
branch
from
6c7cfb5 to
0bb8f0e
Compare
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jpayne3506
approved these changes
Mar 13, 2025
rbtr
approved these changes
Mar 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Replaces the beta.kubernetes.io/os with kubernetes.io/os to fix the cilium nightly pipeline from failing
Issue Fixed:
Requirements:
Notes: