Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool: validator script for Azure NPM to Cilium migration #3372

Merged
merged 75 commits into from
Feb 27, 2025

Conversation

rayaisaiah
Copy link
Contributor

@rayaisaiah rayaisaiah commented Jan 28, 2025

Reason for Change:
Adds a tool to validate cx network polices are safe to migrate from Azure NPM to Cilium.

Issue Fixed:

Requirements:

Notes:

Sorry, something went wrong.

@rayaisaiah rayaisaiah marked this pull request as ready for review February 1, 2025 00:47
@rayaisaiah rayaisaiah requested a review from a team as a code owner February 1, 2025 00:47
testing not done

update

added new check still debugging service check

fixed logic on services with allow all ingress polcies

added checks for allow all ingress policies

added checks for services with allow all policys with empty and label selectors
@rayaisaiah rayaisaiah force-pushed the isaiahraya/npm-cilium-migration-script branch from 34ac8d3 to 087b1c1 Compare February 1, 2025 00:52
Copy link
Contributor

@huntergregory huntergregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Later can we unit test each check? For services, one UT for each case?

@huntergregory huntergregory added npm Related to NPM. linux labels Feb 3, 2025
Copy link
Contributor

@huntergregory huntergregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments on the service check

…s for service and policy maps
…nts log in order to test
… helper to test functions
@rayaisaiah
Copy link
Contributor Author

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

huntergregory
huntergregory previously approved these changes Feb 26, 2025
@rayaisaiah
Copy link
Contributor Author

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rayaisaiah
Copy link
Contributor Author

/azp run Azure Container Networking PR

@rayaisaiah
Copy link
Contributor Author

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rayaisaiah rayaisaiah added this pull request to the merge queue Feb 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2025
@rayaisaiah rayaisaiah added this pull request to the merge queue Feb 27, 2025
Merged via the queue into master with commit c697ff6 Feb 27, 2025
14 checks passed
@rayaisaiah rayaisaiah deleted the isaiahraya/npm-cilium-migration-script branch February 27, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linux npm Related to NPM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants