-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tool: validator script for Azure NPM to Cilium migration #3372
Conversation
testing not done update added new check still debugging service check fixed logic on services with allow all ingress polcies added checks for allow all ingress policies added checks for services with allow all policys with empty and label selectors
34ac8d3
to
087b1c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Later can we unit test each check? For services, one UT for each case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments on the service check
…s for service and policy maps
…nts log in order to test
… helper to test functions
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go
Outdated
Show resolved
Hide resolved
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go
Outdated
Show resolved
Hide resolved
… be a nested loop
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go
Outdated
Show resolved
Hide resolved
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go
Outdated
Show resolved
Hide resolved
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go
Outdated
Show resolved
Hide resolved
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go
Outdated
Show resolved
Hide resolved
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go
Outdated
Show resolved
Hide resolved
…ub.com/Azure/azure-container-networking into isaiahraya/npm-cilium-migration-script
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
tools/azure-npm-to-cilium-validator/azure-npm-to-cilium-validator.go
Outdated
Show resolved
Hide resolved
…ub.com/Azure/azure-container-networking into isaiahraya/npm-cilium-migration-script
01a7b51
/azp run Azure Container Networking PR |
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
Reason for Change:
Adds a tool to validate cx network polices are safe to migrate from Azure NPM to Cilium.
Issue Fixed:
Requirements:
Notes: