Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access Transfer object on message received / support for batching #566

Closed
piotr-rojek opened this issue Apr 20, 2023 · 3 comments
Closed

Comments

@piotr-rojek
Copy link

piotr-rojek commented Apr 20, 2023

Hey,

I am working on Service Bus Emulator and am facing an issue where Service Bus SDK sends a batch. It is an amqp message that contains other amqp messages. This is indicated by setting Message Format field on Transfer to 0x80013700. My current problem is that I don't see how to access this information, as it seems not to be exposed.

I think it would be reasonable to extend IContainer.CreateMessage() with either the whole Transfer object, or just the Message Format value.

REF1 vcabbage/amqp#46 (comment) - comment describing how batching works
REF2 piotr-rojek/devopsifyme-sbemulator#14 - issue I am trying to fix in sbemu

/Piotr

@xinchen10
Copy link
Member

Sounds reasonable. We are enabling access to the message format field on both sender and receiver sides.

@xinchen10
Copy link
Member

Message now has a Format property that sender can set. It will be made available to receivers by the library. The message format is not exposed in IContainer.CreateMessage() because the encoding is still standard AMQP message encoding. We don't support true custom message encoding (a layout different from the standard one).

@piotr-rojek
Copy link
Author

Thanks @xinchen10! When do you expect this to be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants