types(schema): add missing search index types #14449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noseworthy
force-pushed
the
add-search-index-types
branch
from
1bb3f73
to
8393da8
Compare
Support for MongoDB Atlas search indexes was added in [Automattic#14251](Automattic#14251) but the types for `Schema.searchIndex` and the `autoSearchIndex` option were missed. Add these types so that the typescript definitions match the capabilities of the JavaScript version of `mongoose`.
noseworthy
force-pushed
the
add-search-index-types
branch
from
8393da8
to
df9db3c
Compare
vkarpov15
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support for MongoDB Atlas search indexes was added in #14251 but the types for
Schema.searchIndexand theautoSearchIndexoption were missed.Add these types so that the typescript definitions match the capabilities of the JavaScript version of
mongoose.Examples
Not applicable. Just adding type definitions for existing functionality.