types: improve the typing of FilterQuery<T> type to prevent it from only getting typed to any #14436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #14398
Fix #14397
@FaizBShah WDYT?
Summary
#14398 but with a couple of changes:
FilterQuery<RawDocType>
back toFilterQuery<DocType>
for everything butgetFilter()
andgetQuery()
. For some reason, tests fail without thatFilterQuery
types toany
. Here's a couple of TypeScript playground examples demonstrating the issue, which is that withclass Repository<T>
, there's no way to typeT
so thatT
excludes{ id: never }
, andWithId<{ id: never }>
still types to{id: never}
.Examples