Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect return type of findByIdAndDelete() #14190

Closed
2 tasks done
tommybernaciak opened this issue Dec 21, 2023 · 0 comments · Fixed by #14196
Closed
2 tasks done

Incorrect return type of findByIdAndDelete() #14190

tommybernaciak opened this issue Dec 21, 2023 · 0 comments · Fixed by #14196
Labels
typescript Types or Types-test related issue / Pull Request
Milestone
8.0.4

Comments

@tommybernaciak
Copy link

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the bug has not already been reported

Mongoose version

8.0.3

Node.js version

18.18.2

MongoDB server version

6.0.12

Typescript version (if applicable)

No response

Description

The return type for doc.findByIdAndDelete(...) is of type ModifyResult and should be a document

Steps to Reproduce

Screenshot from 2023-12-21 09-07-27

Expected Behavior

Expected that the return type is the document, not ModifyResult
@vkarpov15 vkarpov15 added this to the 8.0.4 milestone Dec 26, 2023
@vkarpov15 vkarpov15 added the typescript Types or Types-test related issue / Pull Request label Dec 26, 2023
vkarpov15 added a commit that referenced this issue Dec 26, 2023
@vkarpov15
types(model): correct return type for findByIdAndDelete()
7d1f4e4 
Fix #14190
vkarpov15 added a commit that referenced this issue Dec 26, 2023
@vkarpov15
types(query): improve findByIdAndDelete return type for query re: #14190
0c7c9bd
@vkarpov15 vkarpov15 mentioned this issue Dec 26, 2023
Merged
vkarpov15 added a commit that referenced this issue Dec 27, 2023
@vkarpov15
Merge pull request #14196 from Automattic/vkarpov15/gh-14190
4b069e8 
Fix return types for findByIdAndDelete overrides
@markiewiczjakub markiewiczjakub mentioned this issue Dec 28, 2023
Closed
2 tasks
vkarpov15 added a commit that referenced this issue Jan 21, 2024
@vkarpov15
types(model): correct return type for findByIdAndDelete()
775aadf 
Fix #14190
vkarpov15 added a commit that referenced this issue Jan 21, 2024
@vkarpov15
types(query): improve findByIdAndDelete return type for query re: #14190
7f9406f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Milestone
8.0.4
Development

Successfully merging a pull request may close this issue.

Fix return types for findByIdAndDelete overrides Automattic/mongoose
2 participants
@vkarpov15 @tommybernaciak