fix(populate): handle multiple spaces when specifying paths to populate using space-delimited paths #13984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te using space-delimited paths Fix #13951
hasezoey
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13951
Summary
Right now,
populate('user fans')will fail with a StrictPopulateError because of the extra space. I think it is sufficiently reasonable to split by multiple spaces, sopopulate('user fans')is equivalent topopulate('user fans'). This may cause issues in cases where path names have whitespace characters, but given that it isn't currently possible to populate a space-delimited path anyway, I don't think that is concerning.Examples