Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(model): add versionKey to bulkWrite when inserting or upserting #13981

Merged
merged 1 commit into from Oct 17, 2023
Merged

fix(model): add versionKey to bulkWrite when inserting or upserting #13981

merged 1 commit into from Oct 17, 2023

Conversation

vkarpov15
Copy link
Collaborator

Fix #13944

Summary

bulkWrite() doesn't currently apply versionKey, __v ends up as undefined if you use bulkWrite([{ insertOne }]) or bulkWrite([{ updateOne: { filter, update, upsert: true } }]). This PR fixes that, along with replaceOne.

Examples

@vkarpov15 vkarpov15 merged commit 68c50c2 into master Oct 17, 2023
42 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-13944 branch October 17, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

version key missing when using bulkWrite insertOne method
2 participants
@vkarpov15 @hasezoey