Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(models): add cleaner type definitions for insertMany() with no generics to prevent errors when using insertMany() in generic classes #13964

Merged
merged 1 commit into from Oct 11, 2023

Conversation

vkarpov15
Copy link
Collaborator

Fix #13957

Summary

Something in the way insertMany() generics are structured causes the errors in #13957. Adding insertMany() overrides that have no generics fixes that, which seems like a reasonable approach.

Examples

…o generics to prevent errors when using `insertMany()` in generic classes

Fix #13957
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic

@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Oct 11, 2023
@vkarpov15 vkarpov15 merged commit 96f71d5 into master Oct 11, 2023
3 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-13957 branch October 11, 2023 19:57
vkarpov15 added a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

insertMany return type changed from version 7.3.2 to 7.3.3
2 participants