Avoid storing a separate entry in schema subpaths for every element in an array
#13953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o avoid `subpaths` growing without bound Re: #13874
Uzlopak
reviewed
Oct 9, 2023
hasezoey
reviewed
Oct 9, 2023
IslandRhythms
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In fix for #3265, we made it so that we store an entry in
subpathsfor every element in an array, presumably to help make it easier to look up array paths. With a little bit of changes, it turns out this is unnecessary; and, as #13874 pointed out, adding an entry tosubpathsfor every element in an array can be considered a memory leak.Examples