Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(npmignore): ignore newer files #13946

Merged
merged 2 commits into from Oct 9, 2023
Merged

chore(npmignore): ignore newer files #13946

merged 2 commits into from Oct 9, 2023

Conversation

hasezoey
Copy link
Collaborator

@hasezoey hasezoey commented Oct 7, 2023 •
edited

Summary

This PR updates the .npmignore to include some files which were added since the last touch to npmignore, mainly:

  • transition from eslintrc.json to .eslintrc.js
  • addition of markdownlint-cli
  • addition of lgtm
  • move of scripts to scripts
  • addition of .mocharc.yml

also excluded tools/, because to my knowledge these are not meant to be shipped, another exclude is tsconfig.json

see https://unpkg.com/browse/mongoose@7.6.0/ for context

@hasezoey
chore(npmignore): ignore newer files
12b82cd 
npmignore has not been updated for some files
@hasezoey hasezoey added the developer-experience This issue improves error messages, debugging, or reporting label Oct 7, 2023
@hasezoey hasezoey added this to the 7.6.1 milestone Oct 7, 2023
@hasezoey hasezoey mentioned this pull request Oct 7, 2023
Merged
vkarpov15
vkarpov15 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 merged commit b6d1aff into Automattic:master Oct 9, 2023
@vkarpov15 vkarpov15 modified the milestones: 7.6.2, 7.6.1 Oct 9, 2023
@hasezoey hasezoey deleted the fixignore branch October 10, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
developer-experience This issue improves error messages, debugging, or reporting
Projects
None yet
Milestone
7.6.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hasezoey @vkarpov15