fix(discriminator): make base schema paths come before discriminator schema paths when running setters, validators, etc. #13846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…schema paths when running setters, validators, etc. Fix #13794
hasezoey
reviewed
Sep 10, 2023
…DiscriminatorSchema
hasezoey
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13794
Summary
Right now, discriminators add base schema paths to the child schema, which means that setters and validators on child schema paths run before setters and validators on base schema paths. This PR switches that order.
While this PR doesn't break any of our tests, I'm considering merging it into 8.0 branch just in case. Any thoughts @hasezoey @AbdelrahmanHafez ?
Examples