New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ChangeStream): add _bindEvents to addListener function #13759

Merged

vkarpov15 merged 1 commit into Automattic:master from yury-ivaniutsenka:fix_change_stream

Aug 22, 2023

yury-ivaniutsenka commented Aug 21, 2023

Summary
ChangeStream doesn't work with fromEvent function from rxjs because this function uses addListener function which doesn't have _bindEvents
https://github.com/ReactiveX/rxjs/blob/master/src/internal/observable/fromEvent.ts#L291

Examples

const productsObservable = fromEvent(
    this.productsModel.watch(),
    'change',
).pipe(map((change) => change.fullDocument));

In current implementation nothing happens


          fix(ChangeStream): add _bindEvents to addListener function

68373c9

vkarpov15 added this to the 7.4.4 milestone

vkarpov15 approved these changes

View reviewed changes

Collaborator

vkarpov15 left a comment

Thanks 👍

vkarpov15 merged commit 812b014 into Automattic:master

17 of 18 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment