Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: export InferSchemaType #13737

Merged
merged 1 commit into from Aug 15, 2023
Merged

types: export InferSchemaType #13737

merged 1 commit into from Aug 15, 2023

Conversation

vkarpov15
Copy link
Collaborator

Summary

TypeScript doesn't seem to care whether we do export InferSchemaType or not, but apparently some IDEs do. Do you know if there's any potential harm in doing this @hasezoey ?

Examples

Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least for me in vscode there are no problems, and as long as there is no duplicate identifier i dont see a problem explicitly exporting this

@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Aug 15, 2023
@vkarpov15 vkarpov15 added this to the 7.4.4 milestone Aug 15, 2023
@vkarpov15 vkarpov15 merged commit 75479a4 into master Aug 15, 2023
3 checks passed
@hasezoey hasezoey deleted the vkarpov15/gh-13710 branch August 15, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants