Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(schema): correct return type for Schema.prototype.indexes() #13718

Merged
merged 1 commit into from Aug 10, 2023
Merged

types(schema): correct return type for Schema.prototype.indexes() #13718

merged 1 commit into from Aug 10, 2023

Conversation

vkarpov15
Copy link
Collaborator

Fix #13702

Summary

Just a quick types fix. Current return value doesn't accurately reflect runtime behavior.

Examples

hasezoey
hasezoey approved these changes Aug 10, 2023
View reviewed changes
types/index.d.ts Show resolved Hide resolved
@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Aug 10, 2023
@vkarpov15 vkarpov15 merged commit a88b73f into master Aug 10, 2023
3 checks passed
@vkarpov15 vkarpov15 added this to the 7.4.3 milestone Aug 10, 2023
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-13702 branch August 10, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fonger Fonger Fonger left review comments

@hasezoey hasezoey hasezoey approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

@IslandRhythms IslandRhythms Awaiting requested review from IslandRhythms

Assignees
No one assigned
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Milestone
7.4.3
Development

Successfully merging this pull request may close these issues.

TypeScript: Schema.issues() return type is incorrect
3 participants
@vkarpov15 @Fonger @hasezoey