types: allow accessing options from pre middleware
#13708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
| type PreSaveMiddlewareFunction<ThisType = any> = ( | ||
| this: ThisType, | ||
| next: CallbackWithoutResultAndOptionalError, | ||
| opts: SaveOptions |
There was a problem hiding this comment.
Any particular reason opts is not optional here, and is optional in PreMiddlewareFunction?
Does it make any difference when defining a last parameter for a function?
There was a problem hiding this comment.
For pre('save'), Mongoose defaults to passing empty options, so for schema.pre('save', function(next, opts) { opts; }) opts will always be defined. Even if you call save() with no args.
Not true for all middleware functions.
AbdelrahmanHafez
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13633
Summary
TypeScript types don't support
optionsparam for document and model middleware currently. This PR adds that.Examples