Correctly clean up nested subdocs modified state on save() #13644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #13609. This issue was pretty tricky at first glance, and I spent a lot of time trying to figure out how to make it so that
pull()
would mark paths in default state as modified. But then I realized the simple solution was to just always call$__reset()
on every subdoc 馃槃 Given that$__reset()
is no longer a bottleneck, this is a better solution because we can now consistently ensure that every individual subdocs' state is reset onsave()
.Examples