Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly clean up nested subdocs modified state on save() #13644

Merged
merged 2 commits into from Jul 23, 2023

Conversation

vkarpov15
Copy link
Collaborator

Summary

Fix #13609. This issue was pretty tricky at first glance, and I spent a lot of time trying to figure out how to make it so that pull() would mark paths in default state as modified. But then I realized the simple solution was to just always call $__reset() on every subdoc 馃槃 Given that $__reset() is no longer a bottleneck, this is a better solution because we can now consistently ensure that every individual subdocs' state is reset on save().

Examples

@vkarpov15 vkarpov15 merged commit ae3894c into master Jul 23, 2023
34 checks passed
@hasezoey hasezoey deleted the vkarpov15/gh-13609 branch July 24, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants