Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types: Add inline comment to to tell the default value of the runValidator flag in the queryOptions types #13636

Merged
merged 1 commit into from Jul 20, 2023
Merged

Types: Add inline comment to to tell the default value of the runValidator flag in the queryOptions types #13636

merged 1 commit into from Jul 20, 2023

Conversation

omran95
Copy link
Contributor

@omran95 omran95 commented Jul 20, 2023 •
edited

Summary

I ran into a small issue when using a function like findOneAndUpdate or updateMany, the runValidator flag in the queryOptions interface is optional but has no information about the default value.

vkarpov15
vkarpov15 approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 7.4.1 milestone Jul 20, 2023
@vkarpov15 vkarpov15 merged commit faf6bf7 into Automattic:master Jul 20, 2023
3 checks passed
@omran95 omran95 deleted the omran95/add-inline-comment-to-runValidators-query-types branch July 20, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.4.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@omran95 @vkarpov15