fix(model): avoid TypeError if insertMany() fails with error that does not have writeErrors
property
#13579
+12
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13531
Summary
This issue is a bit tricky to test, but the idea is that, in the
insertMany()
error handler, theerror
may not necessarily have awriteErrors
property. I was able to repro with the following script by shutting down my MongoDB server in the 10 seconds between "Sleep" and "Executing".With this change, we'll assume that all documents failed to insert if there's an error with no
writeErrors
property.Examples