Move all MongoDB-specific connection logic into driver layer, add createClient() method to handle creating MongoClient
#13542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r, add `createClient()` method to handle creating MongoClient
vkarpov15
requested review from
Uzlopak,
hasezoey,
AbdelrahmanHafez and
IslandRhythms
AbdelrahmanHafez
approved these changes
Jun 25, 2023
hasezoey
approved these changes
Jun 26, 2023
| await Cat.create({ name: 'test123' }); | ||
| let doc = await Cat.findOne({ name: 'test123' }); | ||
| const old = doc.updatedAt; | ||
| await new Promise(resolve => setTimeout(resolve, 10)); |
There was a problem hiding this comment.
what requires this sleep?
There was a problem hiding this comment.
This test flaked once while I was testing, so I figured I'd make this test more robust while it was fresh in my mind. This test doesn't always fail, but you can see that without the sleep this test can fail.
|
Switched base branch to 7.4 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pulling in some work we started on with #4292 work (see vkarpov15/gh-4292 branch). One of the annoying pain points in building the in-memory driver was that we couldn't import Mongoose's
Connectionclass without importing all of MongoDB. The driver layer is supposed to abstract that out, but connections have a bunch of MongoDB references that should really be in the driver layer.Examples