fix(document): allow setting keys with dots in mixed paths underneath nested paths #13536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: hasezoey <hasezoey@gmail.com>
docs(connections+faq): add info on localhost vs 127.0.0.1
… nested paths Fix #13530
vkarpov15
requested review from
Uzlopak,
hasezoey,
AbdelrahmanHafez and
IslandRhythms
AbdelrahmanHafez
approved these changes
Jun 21, 2023
hasezoey
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13530
Summary
This
flattenObjectWithDottedPaths()call was added for #9121 with 98150ac, but it doesn't seem to be necessary - all tests pass without it. As far as I can tell, doesn't look like we need it, all it does is create edge cases where you can't use key names with dots underneath nested paths. But in the interest of caution, we'll move this back to 7.4.Examples