Update README.md #13534
Closed
Update README.md #13534
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like mongoose.Schema.ObjectId has been changed to mongoose.Schema.Types.ObjectId
|
mongoose.Schema.ObjectId was not changed to mongoose.Types.ObjectId . Those are two distinct classes. What makes you think that we removed mongoose.Schema.ObjectId? |
|
Hi @vkarpov15 The reason is VSCode did not recognize
great project. sorry about the confusion. |
|
It looks like our TypeScript type defs don't have |
vkarpov15
added a commit
that referenced
this pull request
Jun 25, 2023
…ma.Types.ObjectId` Fix #13534
|
Closing in favor of #13543 |
vkarpov15
added a commit
that referenced
this pull request
Jun 26, 2023
types: support `mongoose.Schema.ObjectId` as alias for `mongoose.Schema.Types.ObjectId`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading from mongoose 6.x to 7.x i noticed mongoose.Schema.ObjectId has been changed to mongoose.Schema.Types.ObjectId so update the readme to reflect this change