feat(query): delay converting documents into POJOs until query execution, allow querying subdocuments with defaults disabled #13522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion, allow querying subdocuments with defaults disabled Fix #13512
hasezoey
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13512
Summary
This change has a bit wider of a surface area than I'd like, but it should be good for performance and developer experience. The problem in #13512 is that Mongoose converts any query filters to POJOs first, and then recasts subdocument path POJOs back into subdocuments, before converting them to POJOs again; and loses the original settings so there's no way to execute a query on a subdocument path without applying defaults.
With this change, Mongoose will only convert documents in query filters to POJOs once, using the
toBSON()function. Besides fixing #13512, this should make Mongoose faster in cases where you have subdocuments in query filters.The only potential risk is that we're copying documents as POJOs somewhere. That's why I had to add
source = source.toObject(internalToObjectOptions);.Examples