Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: augment bson.ObjectId instead of adding on own type #13515

Merged
merged 1 commit into from Jun 18, 2023
Merged

types: augment bson.ObjectId instead of adding on own type #13515

merged 1 commit into from Jun 18, 2023

Conversation

hasezoey
Copy link
Collaborator

fixes #12537

Summary

This PR changes the Types.ObjectId to not have its own _id declaration anymore but augment bson.ObjectId directly

@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Jun 16, 2023
vkarpov15
vkarpov15 approved these changes Jun 18, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 In the interest of caution, I'll merge this into the 7.4 branch.

@vkarpov15 vkarpov15 added this to the 7.4.0 milestone Jun 18, 2023
@vkarpov15 vkarpov15 changed the base branch from master to 7.4 June 18, 2023 23:56
@vkarpov15 vkarpov15 merged commit f91ff02 into Automattic:7.4 Jun 18, 2023
3 checks passed
@hasezoey hasezoey deleted the augmentbson branch June 19, 2023 09:14
@zhi-qiu-yi zhi-qiu-yi mentioned this pull request Aug 9, 2023
Closed
2 tasks
@theRocket theRocket mentioned this pull request Aug 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

@IslandRhythms IslandRhythms Awaiting requested review from IslandRhythms

Assignees
No one assigned
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Milestone
7.4.0
Development

Successfully merging this pull request may close these issues.

BSON ObjectId is not compatible with Types.ObjectId
2 participants
@hasezoey @vkarpov15