feat(populate): pass virtual to match function to allow merging match options
#13477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasezoey
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
LGTM, maybe consider changing the documentation to reflect that it is now possible (or what changed?) to Populate Virtuals: The Match Option
also Schema.prototype.virtual does not list match as a possible option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12443
Summary
#12443 asks for a way to merge
matchoptions when populated rather than overwriting. Instead of adding yet another new option, I added a new parameter tomatch()function: the virtual definition. That makes it easy to append the virtualmatchto any custom match you want to add.Examples