Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(connection): clarify how Connection.prototype.destroy() is different from close() #13475

Merged
merged 1 commit into from Jun 7, 2023
Merged

docs(connection): clarify how Connection.prototype.destroy() is different from close() #13475

merged 1 commit into from Jun 7, 2023

Conversation

vkarpov15
Copy link
Collaborator

Summary

Current docs for destroy() don't do much to explain why destroy() is different from close().

Examples

@hasezoey hasezoey added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label Jun 4, 2023
AbdelrahmanHafez
AbdelrahmanHafez approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. 👍

@vkarpov15 vkarpov15 added this to the 7.2.3 milestone Jun 7, 2023
@vkarpov15 vkarpov15 merged commit 0b21da6 into master Jun 7, 2023
34 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/destroy-docs branch June 7, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

@IslandRhythms IslandRhythms Awaiting requested review from IslandRhythms

Assignees
No one assigned
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Milestone
7.2.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vkarpov15 @hasezoey @AbdelrahmanHafez