fix: custom debug function not processing all args #13418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
reviewed
May 18, 2023
| @@ -208,8 +208,14 @@ function iter(i) { | |||
|
|
|||
| if (debug) { | |||
| if (typeof debug === 'function') { | |||
| let range = ''; | |||
There was a problem hiding this comment.
Please stop initializing values that aren't strings to empty strings. If you want to add a placeholder value, do let range = null
vkarpov15
approved these changes
May 18, 2023
|
I see this happening on 6.x - could this be backported? (shall I open a PR?) |
|
@forivall sure, if you're able to open a PR that would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13364
Had to fix a couple of tests because of the changes. Let me know if that is not the correct approach.