Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(generateSearch): move config missing error to require #13160

Merged
merged 2 commits into from Mar 13, 2023
Merged

chore(generateSearch): move config missing error to require #13160

merged 2 commits into from Mar 13, 2023

Conversation

hasezoey
Copy link
Collaborator

This PR moves the Error message that was added in 0b7bbbb to the require, where the actual error gets thrown if the config does not exist.

also adds a message on how much content was added.

@hasezoey hasezoey added the developer-experience This issue improves error messages, debugging, or reporting label Mar 13, 2023
@hasezoey hasezoey requested a review from vkarpov15 March 13, 2023 11:31
vkarpov15
vkarpov15 approved these changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks 👍

@vkarpov15 vkarpov15 added this to the 7.0.2 milestone Mar 13, 2023
@vkarpov15 vkarpov15 merged commit 7bf498b into Automattic:master Mar 13, 2023
@hasezoey hasezoey deleted the searchConfigError branch March 13, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
developer-experience This issue improves error messages, debugging, or reporting
Projects
None yet
Milestone
7.0.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hasezoey @vkarpov15