Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type(query): changed QueryOptions lean type to Record<string, any> #13150

Merged
merged 1 commit into from Mar 10, 2023
Merged

type(query): changed QueryOptions lean type to Record<string, any> #13150

merged 1 commit into from Mar 10, 2023

Conversation

lpizzinidev
Copy link
Contributor

Changed the lean attribute of QueryOptions to boolean | Record<string, any> to allow correct inference on a query return type.

closes #13142

vkarpov15
vkarpov15 approved these changes Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 7.0.2 milestone Mar 10, 2023
@vkarpov15 vkarpov15 merged commit c04e329 into Automattic:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.2
Development

Successfully merging this pull request may close these issues.

Remove type any from field lean of interface QueryOptions
2 participants
@lpizzinidev @vkarpov15