Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change API documentation headers to be more unique #13113

Merged
merged 4 commits into from Mar 22, 2023

Conversation

hasezoey
Copy link
Collaborator

@hasezoey hasezoey commented Mar 2, 2023

Summary

This PR changes the API documentation headers to be more unique and now have the style of how they would appear in js itself, also includes a script to translate the old header id's to the new ones.

Notes:
because the old id's did not differentiate between static and instance properties and also not between properties and functions, there are multiple tests to see if one exists in the new style, where the first found is used, current order is:

  • properties first, functions second
  • static first, instance second

closes #12901

Examples:

  • mongoose_Mongoose -> Mongoose()
  • mongoose_Mongoose-model -> Mongoose.prototype.model()
  • model_Model-find -> Model.find()

@hasezoey hasezoey added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label Mar 2, 2023
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 7.0.3 milestone Mar 22, 2023
@vkarpov15 vkarpov15 merged commit 0ddb0f6 into Automattic:master Mar 22, 2023
@hasezoey hasezoey deleted the changeDocsHeaderId branch March 22, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Refactor header naming to lessen conflicts
2 participants