Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/tooltip for watch time videopress card #39030

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

CodeyGuyDylan
Copy link
Contributor

@CodeyGuyDylan CodeyGuyDylan commented Aug 22, 2024

Proposed changes:

  • Fix title for watch time tooltip on VideoPress card
  • Make tooltips shorter (recommended by @ilonagl)

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

P2: p1HpG7-rb7-p2#comment-73468

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  1. Check this branch out on your local environment (you can try this on jurassic tube as well, but switching contexts will be annoying because of the transient that keeps the data if you don't comment it out)
  2. Go to this line of code and comment out the transient
  3. Make sure your local environment is pointing to your sandbox
  4. Make sure your testing site is User connected, has at least 1 video on it, and has VideoPress active
  5. Now to go to this line of code on the backend: fbhepr%2Skers%2Sjcpbz%2Schoyvp.ncv%2Serfg%2Sjcpbz%2Qwfba%2Qraqcbvagf%2Spynff.jcpbz%2Qwfba%2Qncv%2Qfgngf%2Qivqrb%2Qcynlf%2Qi1%2Q1%2Qraqcbvag.cuc%3Se%3Q210o65nn%26zb%3Q1199%26sv%3Q37%2350-og and replace the 0's with
'impressions' => wp_rand( 0, 300 ),
'views'       => wp_rand( 0, 300 ),
'watch_time'  => wp_rand( 0, 5 ),
  1. Refresh My Jetpack and make sure the Watch time tooltip makes sense
    image

Sorry, something went wrong.

Copy link
Contributor

github-actions bot commented Aug 22, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/tooltip-for-watch-time-videopress-card branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/tooltip-for-watch-time-videopress-card
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Aug 22, 2024
Copy link
Contributor

@IanRamosC IanRamosC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CodeyGuyDylan CodeyGuyDylan merged commit 71503a6 into trunk Aug 22, 2024
72 of 73 checks passed
@CodeyGuyDylan CodeyGuyDylan deleted the fix/tooltip-for-watch-time-videopress-card branch August 22, 2024 16:57
@github-actions github-actions bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Aug 22, 2024
pkuliga pushed a commit that referenced this pull request Aug 23, 2024
* Fix tooltip title for watch time on videopress card

* changelog

* Make tooltip descriptions shorter
gogdzl pushed a commit that referenced this pull request Oct 25, 2024
* Fix tooltip title for watch time on videopress card

* changelog

* Make tooltip descriptions shorter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants