Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: instanceof in override function compile as unreachable #2661

Merged
merged 2 commits into from Mar 3, 2023
Merged

fix: instanceof in override function compile as unreachable #2661

merged 2 commits into from Mar 3, 2023

Conversation

HerrCai0907
Copy link
Member

fix: #2660

switch the order of compile pending instanceof helpers and set up override stubs

@dcodeIO dcodeIO merged commit 9497c3d into AssemblyScript:main Mar 3, 2023
@dcodeIO
Copy link
Member

dcodeIO commented Mar 3, 2023

Good catch, thanks!

@HerrCai0907 HerrCai0907 deleted the fix/unreachabel-instanceof branch March 3, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generate null instanceof function
2 participants
@HerrCai0907 @dcodeIO