Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect recursive types early #2634

Merged
merged 3 commits into from Jan 24, 2023
Merged

Detect recursive types early #2634

merged 3 commits into from Jan 24, 2023

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Jan 24, 2023

Fixes #2633 by detecting recursive types, that are not supported yet. during resolve. Also touches detection of circular type aliases, which is related, simplifying the code a bit.

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@dcodeIO dcodeIO requested a review from MaxGraey January 24, 2023 13:43
@MaxGraey
Copy link
Member

MaxGraey commented Jan 24, 2023 •
edited

Does it make sense to add some additional tests?

@dcodeIO dcodeIO merged commit bcfb5e8 into main Jan 24, 2023
@HerrCai0907 HerrCai0907 deleted the issue-2633 branch October 17, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxGraey MaxGraey MaxGraey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolver crasher on recursive types
2 participants
@dcodeIO @MaxGraey