Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle all possible element kinds when walking exports #2631

Merged
merged 1 commit into from Jan 22, 2023
Merged

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Jan 22, 2023

Fixes #2611 (I suppose), where it was discovered that some possible export kinds are not yet handled when walking exports during bindings generation, most notably exported interfaces.

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@dcodeIO dcodeIO requested a review from MaxGraey January 22, 2023 17:04
Copy link
Member

@MaxGraey MaxGraey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dcodeIO dcodeIO merged commit e06c7bc into main Jan 22, 2023
@HerrCai0907 HerrCai0907 deleted the issue-2611 branch October 17, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encounter an compiler error after translate a TS lib to assemblyscript
2 participants