Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: analysis ParenthesizedExpression or FunctionExpression correctly in parser (#2605) #2620

Merged
merged 2 commits into from Jan 19, 2023
Merged

fix: analysis ParenthesizedExpression or FunctionExpression correctly in parser (#2605) #2620

merged 2 commits into from Jan 19, 2023

Conversation

HerrCai0907
Copy link
Member

fix parser error for a ? (b) : c in #2605

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@HerrCai0907 HerrCai0907 force-pushed the fix/parser-ternary-expression-with-parenthesis branch from 40a104c to b66617a Compare January 17, 2023 16:09
@HerrCai0907 HerrCai0907 force-pushed the fix/parser-ternary-expression-with-parenthesis branch from b66617a to ee3995b Compare January 17, 2023 16:13
dcodeIO
dcodeIO reviewed Jan 18, 2023
View reviewed changes
src/parser.ts Outdated Show resolved Hide resolved
@HerrCai0907 @dcodeIO
Update src/parser.ts
306249a 
Co-authored-by: dcode <dcode@dcode.io>
@dcodeIO dcodeIO merged commit c0a0fd0 into AssemblyScript:main Jan 19, 2023
@dcodeIO
Copy link
Member

dcodeIO commented Jan 19, 2023

Thanks :)

@HerrCai0907 HerrCai0907 deleted the fix/parser-ternary-expression-with-parenthesis branch January 19, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HerrCai0907 @dcodeIO