Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat asyncapi: add commands to manage schema inheritance #842

Conversation

ben-lc
Copy link
Contributor

@ben-lc ben-lc commented Nov 25, 2024

Currently using schema inheritance in apicurio with asyncapi is broken. This PR adds required commands to handle it:

  • AddChildSchemaCommand_Aai20
  • ChangeSchemaTypeCommand_Aai20
  • ChangeSchemaInheritanceCommand_Aai20
  • DeleteAllChildSchemasCommand_Aai20
  • DeleteChildSchemaCommand_Aai20

@EricWittmann
Copy link
Member

LGTM thanks @ben-lc

FYI I wanted to let you know that I'm in the process of slowly migrating the commands in 1.x over to 2.x. I may be trying to also simplify or at least collapse the number of commands we have where possible.

We have also begun a rewrite of the editor using React. If you are interested, you can find the work here:

https://github.com/Apicurio/apicurio-editors

@EricWittmann EricWittmann merged commit e4897b1 into Apicurio:1.x Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants