Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build script #24

Closed
Anders429 opened this issue Dec 18, 2023 · 0 comments · Fixed by #32
Closed

Remove build script #24

Anders429 opened this issue Dec 18, 2023 · 0 comments · Fixed by #32

Comments

@Anders429
Copy link
Owner

Anders429 commented Dec 18, 2023

The only thing the build script does is check whether 128-bit integers are supported. However, serde stopped supporting conditional compilation based on 128-bit integers with serde-rs/serde#2600, released in version 1.0.187. The macro used here technically still exists, but it is a no-op.

Since this crate doesn't support rustc versions older than 1.40 (and never has), it seems reasonable to remove this from the build script.

This was referenced Dec 18, 2023
@Anders429 Anders429 linked a pull request Dec 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant