Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ng add @o3r/eslint-config-otter adds Jest dependency for non-Jest projects #1662

Open
vscaiceanu-1a opened this issue Apr 15, 2024 · 1 comment
Labels
bug Something isn't working priority:medium

Comments

@vscaiceanu-1a
Copy link
Member

Package name

eslint-config-otter

Package version

10.1.5

Reproduction steps

npm create @o3r otter-project
cd otter-project
ng g application webapp
# choose preset BASIC, NO Jest and NO Playwright when prompted
ng add @o3r/eslint-config-otter

Current result

Jest is added as dependency even if the project does not use Jest.

Expected result

Jest shouldn't be added by the eslint-config-otter ng add command.

Additional comments

No response

@vscaiceanu-1a vscaiceanu-1a added the bug Something isn't working label Apr 15, 2024
@vscaiceanu-1a
Copy link
Member Author

When adding eslint-config-otter on a project, we should first check is jest is installed. If not, we don't add eslint-plugin-jest.
When adding @o3r/testing we should check if eslint-config-otter. If it is the case, we should add eslint-plugin-jest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:medium
Projects
None yet
Development

No branches or pull requests

2 participants