Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Less code when generating @o3r/workspace:application #1659

Open
ADR-Clizy opened this issue Apr 15, 2024 · 1 comment
Open

[Feature]: Less code when generating @o3r/workspace:application #1659

ADR-Clizy opened this issue Apr 15, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ADR-Clizy
Copy link

Context

I generated a basic web app with o3r/workspace:application where I only need a router inside of it.

In the app.config I saw this

image

Which include a lot of complexity with Reducer / LocalStorage etc...

Also in dev additionnal module :

image

Proposal

Maybe we want to have a cleaner default app with only router.

I cleaned up everything and finish with this :

image
image

In my point of view, it avoid to much complexity. As a beginner using this framework, it's more comfortable :)

@ADR-Clizy ADR-Clizy added the enhancement New feature or request label Apr 15, 2024
@kpanot
Copy link
Contributor

kpanot commented Apr 16, 2024

Thank you @ADR-Clizy for the proposal.

Let me translate your request in technical terms to facilitate the implementation:

  • The StorageSync should be setup in the application only on the add of @o3r/store-sync
  • The package @o3r/store-sync should be installed only if it is part of a preset
  • The load of EffectsModule, StoreModule and the runtimeCheck should be added to the application by the ng-add of a package depending on NgRx.
  • ⚠️ The package @o3r/application and the registration of the basic devtools modules should per default and still be added by the ng-add of @o3r/core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants