Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omit unnecessary spaces around <b>, <em>, and <strike> #342

Merged
merged 1 commit into from
May 5, 2021

Conversation

snarfed
Copy link
Contributor

@snarfed snarfed commented Dec 6, 2020

fixes #324

@snarfed snarfed changed the title omit unnecessary spaces around <b>, <em>, and strike omit unnecessary spaces around <b>, <em>, and <strike> Dec 6, 2020
@coveralls
Copy link

coveralls commented Dec 6, 2020

Coverage Status

Coverage increased (+0.2%) to 97.026% when pulling d127b77 on snarfed:no-inline-space into 4592133 on Alir3z4:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-96.8%) to 0.0% when pulling 8e8c1bc250f4636092ce0714b9ad425deabed38f on snarfed:no-inline-space into 4235c1a on Alir3z4:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-96.8%) to 0.0% when pulling 8e8c1bc250f4636092ce0714b9ad425deabed38f on snarfed:no-inline-space into 4235c1a on Alir3z4:master.

@djdembeck
Copy link

Noticed these problems as well. Any chance this can be merged?

@Alir3z4 Alir3z4 merged commit 8d7dc2f into Alir3z4:master May 5, 2021
@Alir3z4
Copy link
Owner

Alir3z4 commented May 5, 2021

@snarfed @djdembeck just merged this in and I noticed it failed on master.
Could you please let me know if you could troubleshoot?

@Alir3z4
Copy link
Owner

Alir3z4 commented May 5, 2021

snarfed added a commit to snarfed/html2text that referenced this pull request May 5, 2021
@snarfed
Copy link
Contributor Author

snarfed commented May 5, 2021

Sure! Done, in #357. Looks like this one collided with #333, which was merged after this PR passed CI but before it was merged.

snarfed added a commit to snarfed/bridgy that referenced this pull request May 5, 2021
@Alir3z4
Copy link
Owner

Alir3z4 commented May 5, 2021

Excellent!

Alir3z4 added a commit that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary spaces around <b></b>
4 participants