This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
feat: Add Description function to multi select #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for submitting this! Please bear with us while we catch up on a lot of PRs that are piling up. We appreciate your patience |
AlecAivazis
suggested changes
Aug 29, 2022
There was a problem hiding this comment.
Hey @Konkrad I finally got around to taking a look at this PR and I noticed there are no tests - mind adding something to tests/multiselect.go that showcases the behavior?
|
Hello, |
|
Okay, finally found some time to pull this down and check it out. I'm seeing some weird coloring when I have a description set:
|
|
Indeed, thanks, I forgot to reset the color. Fixed it. Is there a way to add a test case for this? |
|
Looks good! I just pushed up a test. Will merge once we get the 👍 from github |
AlecAivazis
approved these changes
Sep 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopting the Description function from select to multi select as proposed in #432