This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
Added customisable hide character for password inputs. #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes example, but is missing a test mend
|
Thanks for putting this together @SirRegion! Mind putting a little note in the docs about the zero space width? |
|
@SirRegion there is now a merge conflct. I'd be happy to merge this once its ready (I can add the documentation after) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @AlecAivazis and @mislav!
I had some free time so I tried my hand on implementing #386.
Changing the hide character of the password field works as expected. However, using an empty rune just results in the characters not getting hidden at all.
The best workaround for this is setting the custom hide character to an zero width space. This results in the behaviour required by the original poster.
I included an example for the password input, but I did not write a test for the behaviour. I also noticed that the existing password tests don't actually validate that the input is hidden, just that is is stored correctly. I'm sadly incapable of fixing those two issues.