Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add licenseInformation, add tier test and honor onlyWWW #594

Merged
merged 3 commits into from
Mar 5, 2024
Merged

add licenseInformation, add tier test and honor onlyWWW #594

merged 3 commits into from
Mar 5, 2024

Conversation

mcm1957
Copy link
Contributor

@mcm1957 mcm1957 commented Feb 24, 2024 •
edited by AlCalzone

This PR adapts tests as following:

fixes #592

  • if common.licenseInformation is present common.license must not exist
  • package.license is compared againts eitehr io-package.common.license or iopackage.common.licenseInformation.license
  • common.licenseInformation is checked to be an object containing required components

fixes #577

  • if common.onlyWWW is set package.json need no longer have a main attribute

Additonal

  • common.tier is checked to be between 1 and 3 if present.

@mcm1957
Copy link
Contributor Author

mcm1957 commented Feb 24, 2024 •
edited

@AlCalzone

Please verify / check, merge and release
If any changes are required, please let me know

@Apollon77
Please review if you like

This was referenced Feb 24, 2024
Closed
Closed
AlCalzone
AlCalzone requested changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things

src/tests/packageFiles/index.ts Outdated Show resolved Hide resolved
src/tests/packageFiles/index.ts Outdated Show resolved Hide resolved
src/tests/packageFiles/index.ts Outdated Show resolved Hide resolved
@AlCalzone AlCalzone merged commit ec79ddb into ioBroker:master Mar 5, 2024
8 checks passed
@AlCalzone AlCalzone deleted the dev branch March 5, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCalzone AlCalzone AlCalzone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mcm1957 @AlCalzone