feat(config): add Shelly Wave 1, Wave 2PM, update Wave 1PM association labels #6326
+683
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 26, 2023 12:09
Added configuration file for the Qubio Wave 1. Associations, Parameters and Inclusion, exclusion, reser metadata.
configuration file include associations, Parameters and metadata for inclusion, exclusion and reset
QubinoHelp
changed the title
QubinoHelp
changed the title
AlCalzone
changed the title
AlCalzone
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Thanks a lot!
FYI, I've very recently (several minutes ago) added a few custom lint rules to help with config files.
If your local development setup follows our recommendations, VSCode will highlight unnecessary properties and automatically remove them when saving the file.
2 tasks
AlCalzone
added a commit
that referenced
this pull request
Sep 29, 2023
### Bugfixes * Ignore when a node reports `Security S0/S2 CC` to have version 0 (unsupported) although it is using that CC (#6333) ### Config file changes * Add Shelly to manufacturers (#6339) * Add Shelly Wave 1, Wave 2PM, update Wave 1PM association labels (#6326) * Add Sunricher SR-ZV2833PAC (#6310) ### Changes under the hood * Added an ESLint rule to help with deciding whether a config parameter needs to be `unsigned` or not (#6325, #6338)
|
Thank you I will review the recommendations you're pointing out. Will add a new device next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Wave 1 added zwavealliance id
feat: config new device Wave 2PM
fix: Wave 1PM association text