feat(config): add Sunricher SR-ZV2833PAC #6310
Merged
+215
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found this in OpenSmartHouse DB Should close #5850 as help wanted, so giving it a go. Do not have the device, so can't test Signed-off-by: Bob Eckhoff <katmandodo@yahoo.com>
|
I see an issue with the allowManualEntry from the wizard extracted file. Not sure exactly what that means. It seems to be picking up the "Limit to Options" flag in the OpenSmartHouse DB. What that means in OpenHAB terms is only the options shown are allowed, whereas I literally read allowManualEntry as meaning as the opposite, so need to understand better to fix without messing this up for a device owner. |
Correct allowManualEntry params that were incorrectly configured from the zwave-js OpenSmartHouse script Signed-off-by: Bob Eckhoff <katmandodo@yahoo.com>
Parameter 7 and 8 had in coorect max values that I hadn't noticed Signed-off-by: Bob Eckhoff <katmandodo@yahoo.com>
AlCalzone
requested changes
Sep 25, 2023
|
Just a comment before I get into this; This disabuses me of the idea I could rip through 4-5 of these by simply extracting from the Open Smart House DB. I was starting to suspect that was too easy to be true. Now I'll have to read the docs ;-) |
|
Yeah, we have probably the highest standards of all projects when it comes to config params. |
First attempt to address comments. I might have an issue we'll if this tests okay... Signed-off-by: Bob Eckhoff <katmandodo@yahoo.com>
understand docs better Signed-off-by: Bob Eckhoff <katmandodo@yahoo.com>
AlCalzone
previously approved these changes
Sep 26, 2023
AlCalzone
changed the title
AlCalzone
approved these changes
Sep 26, 2023
AlCalzone
added a commit
that referenced
this pull request
Sep 29, 2023
### Bugfixes * Ignore when a node reports `Security S0/S2 CC` to have version 0 (unsupported) although it is using that CC (#6333) ### Config file changes * Add Shelly to manufacturers (#6339) * Add Shelly Wave 1, Wave 2PM, update Wave 1PM association labels (#6326) * Add Sunricher SR-ZV2833PAC (#6310) ### Changes under the hood * Added an ESLint rule to help with deciding whether a config parameter needs to be `unsigned` or not (#6325, #6338)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this in OpenSmartHouse DB Should close #5850 as help wanted, so giving it a go. Do not have the device, so can't test
PR description here