Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Update winit to 0.30 #397

Merged
merged 3 commits into from
Apr 30, 2024
Merged

fix!: Update winit to 0.30 #397

merged 3 commits into from
Apr 30, 2024

Conversation

DataTriny
Copy link
Member

Examples now use the new ApplicationHandler trait, which led to significant changes.

This is a breaking change to accesskit_winit, as described in the changelog.

@mwcampbell
Copy link
Contributor

In the examples, I don't see any reason why the Windo needs to be wrapped in an Arc. The Arc is never cloned, only borrowed.

Aside from that, this looks good.

@DataTriny
Copy link
Member Author

That was a leftover from the official winit example. Fixed now.

@mwcampbell mwcampbell merged commit de93be3 into main Apr 30, 2024
10 checks passed
@mwcampbell mwcampbell deleted the update-winit branch April 30, 2024 13:39
@mwcampbell mwcampbell mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants