refactor!: Clean up table roles and properties #393
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The roles and properties that I copied from Chromium are complicated compared to the ARIA standard, and the meanings of the various properties were never documented. I think that if the ARIA roles, properties, and (lack of) relations are good enough for both GTK 4 and ARIA itself, they're probably good enough for us, too. I'm quite sure we don't need the
Column
role; it doesn't even have a proper mapping on two of the three platforms. As for the oldtable_header
,table_row_header
, andtable_column_header
relations, I guess the AT (or in our case, maybe the consumer library) should scan for the headers rather than requiring the toolkit to specify such relations; there are certainly no such relations in ARIA.The new
row_index_text
andcolumn_index_text
properties are based on ARIA properties that are also in GTK 4, that we didn't previously have.