Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Clean up table roles and properties #393

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

mwcampbell
Copy link
Contributor

The roles and properties that I copied from Chromium are complicated compared to the ARIA standard, and the meanings of the various properties were never documented. I think that if the ARIA roles, properties, and (lack of) relations are good enough for both GTK 4 and ARIA itself, they're probably good enough for us, too. I'm quite sure we don't need the Column role; it doesn't even have a proper mapping on two of the three platforms. As for the old table_header, table_row_header, and table_column_header relations, I guess the AT (or in our case, maybe the consumer library) should scan for the headers rather than requiring the toolkit to specify such relations; there are certainly no such relations in ARIA.

The new row_index_text and column_index_text properties are based on ARIA properties that are also in GTK 4, that we didn't previously have.

@mwcampbell
Copy link
Contributor Author

Oh, and I dropped the table_ prefix from the property names because, as with hierarchical_level, long names are just more cumbersome.

@DataTriny
Copy link
Member

I fixed merge conflicts from #390. I'll merge now.

@DataTriny DataTriny merged commit e34dad9 into main Apr 30, 2024
10 checks passed
@DataTriny DataTriny deleted the table-cleanup branch April 30, 2024 10:34
@mwcampbell mwcampbell mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants